Skip to content

Commit

Permalink
fix(hubble): hub operator fid is not set docker compose (farcasterxyz…
Browse files Browse the repository at this point in the history
…#2129)

## Motivation

Fixes farcasterxyz#2088 farcasterxyz#2117 

There is likely an underlying issue with the commander configuration but
this is a quick change that gets this working for those having trouble
getting the container up and running.

## Change Summary

Reordered CLI arguments in docker-compose.yml.

## Merge Checklist

_Choose all relevant options below by adding an `x` now or at any time
before submitting for review_

- [x] PR title adheres to the [conventional
commits](https://www.conventionalcommits.org/en/v1.0.0/) standard
- [x] PR has a
[changeset](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#35-adding-changesets)
- [x] PR has been tagged with a change label(s) (i.e. documentation,
feature, bugfix, or chore)
- [ ] PR includes
[documentation](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#32-writing-docs)
if necessary.
- [x] All [commits have been
signed](https://github.com/farcasterxyz/hub-monorepo/blob/main/CONTRIBUTING.md#22-signing-commits)

## Additional Context

If this is a relatively large or complex change, provide more details
here that will help reviewers


<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the `docker-compose.yml` file for the
`@farcaster/hubble` app to fix an issue with CLI arguments order
affecting the hub operator FID.

### Detailed summary
- Added `--hub-operator-fid ${HUB_OPERATOR_FID:-0}` to fix unset hub
operator FID in docker-compose.yml.
- Rearranged CLI arguments to ensure correct order and parameter
assignment.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`

<!-- end pr-codex -->
  • Loading branch information
aquaticone authored Jul 8, 2024
1 parent 4518058 commit 795815a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/new-kids-provide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@farcaster/hubble": patch
---

fixed issue with cli arguments order in docker-compose.yml causing hub operator fid to be unset
2 changes: 1 addition & 1 deletion apps/hubble/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ services:
--eth-mainnet-rpc-url $ETH_MAINNET_RPC_URL
--l2-rpc-url $OPTIMISM_L2_RPC_URL
--network ${FC_NETWORK_ID:-1}
--hub-operator-fid ${HUB_OPERATOR_FID:-0}
--rpc-subscribe-per-ip-limit ${RPC_SUBSCRIBE_PER_IP_LIMIT:-4}
-b ${BOOTSTRAP_NODE:-/dns/nemes.farcaster.xyz/tcp/2282}
--statsd-metrics-server $STATSD_METRICS_SERVER
--hub-operator-fid ${HUB_OPERATOR_FID:-0}
--opt-out-diagnostics ${HUB_OPT_OUT_DIAGNOSTICS:-false}
${HUB_OPTIONS:-}
ports:
Expand Down

0 comments on commit 795815a

Please sign in to comment.