Make traffic stats accurate #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt's QJson can't handle large integers [1]. As a result traffic statistics is inaccurate when tens of gigabytes are transferred. On the other hand, jsoncpp can handle 64-bit integers, which are sufficient as syncthing uses 64-bit integers, too [2]. Enabled testing on macOS only as XXX_LINK_LIBRARIES requires a quite new CMake (3.12). [1] https://bugreports.qt.io/browse/QTBUG-28560 [2] https://github.com/syncthing/syncthing/blob/v1.1.4/lib/protocol/protocol.go#L905-L909
|
Enabling JSONCPP on ancient Ubuntu appears very difficult. I made jsoncpp optional and test it on macOS only. |
|
This project appears abandoned (#247), and I've switched to https://github.com/Martchus/syncthingtray, so closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt's QJson can't handle large integers [1]. As a result traffic statistics is inaccurate when tens of gigabytes are transferred. On the other hand, jsoncpp can handle 64-bit integers, which are sufficient as syncthing uses 64-bit integers, too [2].
To see the effects of inaccurate statistics, trasnfer 10GB of data within syncthing and then transfer some tiny files (e.g., a few KB). You will see the tray icon rotates for a long time.
Not sure if it's a good idea or not to add one more dependency. jsoncpp is a dependency of cmake, so it should already be there if one can build QSyncthingTray. I can also try to make jsoncpp optional and fallback to QJson if you wish.
[1] https://bugreports.qt.io/browse/QTBUG-28560
[2] https://github.com/syncthing/syncthing/blob/v1.1.4/lib/protocol/protocol.go#L905-L909