Skip to content

Conversation

viladimiru
Copy link

@viladimiru viladimiru commented Sep 22, 2025

After reading the MySQL documentation, I understood that the sha256_password plugin works partially correctly, but it did not account for the fact that manual encryption is not required when connecting via TLS.

documentation

Follow up for #2888

@viladimiru viladimiru changed the title fix: Fix sha256_password to work correctly over a TLS connection fix: fix sha256_password to work correctly over a TLS connection Sep 22, 2025
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (ef47e49) to head (93ebb2c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/auth_plugins/sha256_password.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3809      +/-   ##
==========================================
- Coverage   89.83%   89.80%   -0.04%     
==========================================
  Files          86       86              
  Lines       13596    13601       +5     
  Branches     1606     1606              
==========================================
  Hits        12214    12214              
- Misses       1382     1387       +5     
Flag Coverage Δ
compression-0 88.91% <0.00%> (-0.04%) ⬇️
compression-1 89.78% <0.00%> (-0.04%) ⬇️
static-parser-0 87.37% <0.00%> (-0.04%) ⬇️
static-parser-1 88.14% <0.00%> (-0.04%) ⬇️
tls-0 89.22% <0.00%> (-0.04%) ⬇️
tls-1 89.57% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wellwelwel wellwelwel linked an issue Sep 22, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sha256_password auth plugin doesn't work via TLS connection
1 participant