Logout(): Resting current/sessionToken before throwing exception #30
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidiabale
reviewed
Apr 19, 2018
| @@ -320,11 +320,11 @@ public void logout() throws ParseException { | |||
| ParseCommand command = new ParsePostCommand(ENDPOINT_LOGOUT); | |||
| command.addHeader(ParseConstants.HEADER_SESSION_TOKEN, getSessionToken()); | |||
| ParseResponse response = command.perform(); | |||
| setSessionToken(null); | |||
There was a problem hiding this comment.
@ahmedengu Why would it make more sense to reset the session and current user before checking whether the action succeeded. In my opinion the original implementation makes more sense i.e. resetting only after a successful deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
This prevent sending the old session token with following requests, Also resting the current user prevent unexpected behaviors thus the developer will always expect that the current user is null after calling logout().
This what happens with the js sdk, the user object saved in the local storage is deleted regardless of the response.
Best Regards,
Ahmed