fix: name diskSelector in UnattendedInstallConfig validation errors - #14214
Merged
talos-bot merged 1 commit intoSep 2, 2026
Merged
Conversation
shanduur
approved these changes
Sep 2, 2026
46 tasks
`ProvisioningSpec.Validate` reported `provisioning.volumeSelector.match`, but the field is `provisioning.diskSelector`. There is no `volumeSelector` key in `UnattendedInstallConfig`, so the message pointed at a field that does not exist. Both strings are identical to the ones in `LVMVolumeGroupConfig` and `RAIDArrayConfig`, where `volumeSelector` is the correct name; this type appears to have been derived from one of those and the field renamed to `diskSelector` without the messages following. Signed-off-by: Oscar Wieman <oscar@oscarr.nl>
shanduur
force-pushed
the
fix/unattended-install-diskselector-error
branch
from
September 2, 2026 10:15
7178e36 to
7fd43a4
Compare
Member
|
/m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? (description)
ProvisioningSpec.Validatenamesprovisioning.volumeSelector.match, but the field isprovisioning.diskSelector— there is novolumeSelectorkey anywhere inUnattendedInstallConfig.Changes the two strings, the three test assertions covering them, and one subtest name. No behaviour change.
Why? (reasoning)
Fixes #14213.
Both strings are byte-identical to the ones in
LVMVolumeGroupConfigandRAIDArrayConfig, wherevolumeSelectoris the correct field name. This type looks to have been derived from one of those and the field renamed todiskSelectorwithout the messages following. Present since 4160737, the type's first commit.Backport to
release-1.14? This is the first error some people will meet on 1.14 — at least one config generator currently emitsprovisioning: {}, so the message lands before anything else does. It would be good to have in 1.14.0 rather than waiting for 1.15. Happy to open the backport PR if you want it.Acceptance
make conformance)make fmt)make lint)make docs)make unit-tests)