Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read domain and prefix ENVs for GitHub Enterprise #39

Closed
wants to merge 5 commits into from

Conversation

JimmyMultani
Copy link

@JimmyMultani JimmyMultani commented May 15, 2020

Expose domain and prefix variables so they can be read for repositories that are not hosted on GitHub, like GitHub Enterprise.

Fixes #40.

@JimmyMultani
Copy link
Author

JimmyMultani commented May 15, 2020

Not really sure how one would be able to write tests for this without exposing private information, TBH.

@JimmyMultani JimmyMultani marked this pull request as ready for review May 15, 2020 16:36
@JimmyMultani
Copy link
Author

Hey @siddharthkp, would appreciate your feedback on this.

@JimmyMultani
Copy link
Author

@siddharthkp, can you please take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read domain and prefix paths from CI ENVs
2 participants