Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GITHUB_TOKEN from token.js #357

Closed
wants to merge 1 commit into from

Conversation

alexbbt
Copy link

@alexbbt alexbbt commented Mar 11, 2020

Description

Remove the GITHUB_TOKEN from token.js, Instead it should only use the project specific BUNDLESIZE_GITHUB_TOKEN

Motivation and Context

This was causing an error with generic CI tokens, #93

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I created an issue for the Pull Request

This was causing an error with generic CI tokens, this should only use a project specific token, closes siddharthkp#93
@alexbbt alexbbt marked this pull request as ready for review March 11, 2020 18:19
@reznord
Copy link
Collaborator

reznord commented Mar 11, 2020

I'm afraid this might break for the people who are using github_token.

cc @siddharthkp

@alexbbt
Copy link
Author

alexbbt commented Mar 11, 2020

@reznord Could they not change the name of their variable?

@siddharthkp
Copy link
Owner

Sorry, have to say no to this to keep old builds working.

Could they not change the name of their variable?

They could, but

  1. communicating that change is hard. It will have to be a major version release and mentioned in the change log for folks upgrading
  2. it's a very small convenience that the library can absorb without requiring a change from all its users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants