Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make brotli-size optional #214

Merged
merged 8 commits into from
May 2, 2018
Merged

Make brotli-size optional #214

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d783078
Move brotli-size to optionalDependencies
styfle Apr 13, 2018
0387ea4
Add warning "Missing optional dependency"
styfle Apr 13, 2018
c9165fa
Bump brotli-size to 0.0.2
styfle Apr 14, 2018
52e72bd
Use prettycli to warn
styfle Apr 14, 2018
589833a
Change brotli-size to peerDependencies
styfle Apr 23, 2018
5e89752
Add note about peer depdendency for brotli-size
styfle Apr 23, 2018
088e8f7
Remove brotli-size
styfle Apr 23, 2018
eecc3f9
Move try/catch around require
styfle Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"license": "MIT",
"dependencies": {
"axios": "^0.17.0",
"brotli-size": "0.0.1",
"bytes": "^3.0.0",
"ci-env": "^1.4.0",
"commander": "^2.11.0",
Expand All @@ -49,6 +48,9 @@
"prettycli": "^1.4.3",
"read-pkg-up": "^3.0.0"
},
"optionalDependencies": {
"brotli-size": "0.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated to 0.0.2 at the same time? :-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey that sounds like a good idea considering the size of the package decreased significantly https://packagephobia.now.sh/[email protected]

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddharthkp What do you think?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any difference in size because of that?

Copy link
Author

@styfle styfle Apr 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

I will bump the version to 0.0.2

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

},
"bundlesize": [
{
"path": "./index.js",
Expand Down
8 changes: 6 additions & 2 deletions src/compressed-size.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const gzip = require('gzip-size')
const brotli = require('brotli-size')

const getCompressedSize = (data, compression = 'gzip') => {
let size
Expand All @@ -8,7 +7,12 @@ const getCompressedSize = (data, compression = 'gzip') => {
size = gzip.sync(data)
break
case 'brotli':
size = brotli.sync(data)
try {
const brotli = require('brotli-size')
size = brotli.sync(data)
} catch (e) {
console.warn('Missing optional dependency: brotli-size')
Copy link
Owner

@siddharthkp siddharthkp Apr 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this slightly more instructional + use prettycli (already declared as dependency), that will let you add nice multiline warnings.

WARN Missing optional dependency. Install it with:

npm install brotli-size

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ✅

}
break
case 'none':
default:
Expand Down