-
Notifications
You must be signed in to change notification settings - Fork 12
adding the DESI BAO likelihood #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 99.09% 99.12% +0.03%
==========================================
Files 51 54 +3
Lines 2752 2848 +96
==========================================
+ Hits 2727 2823 +96
Misses 25 25
🚀 New features to boost your workflow:
|
sibirrer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @martin-millon. I have a minor comment and hope the tests can be improved
…into BAO-martin
…into BAO-martin
…into BAO-martin
|
@sibirrer, this is ready to be merged (with the caveat that you have to sample r_d and that CosmoInterp can't be used). |
sibirrer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @martin-millon !
This is a draft for now. I am missing :
automatic tests
handling of the CosmoInterp class (cosmology class must have a H(z) function to be compatible with the BAO likelihood) (return an error for the moment)
r_d computation (instead of sampling from a flat prior). This requires some early physics computation, which depends on omega_b and omega_gamma. This is probably unnecessary if no information from BBN or CMB is provided.(return an error for the moment)
This is tested here: https://github.com/TDCOSMO/7LensMilestone/blob/main/Likelihoods/BAOLikelihood/test_sampling_DESI_DR2.ipynb
It reproduces the DESI DR2 results in w0waCDM, in combination with Pantheon+.