Skip to content

Conversation

@martin-millon
Copy link
Collaborator

@martin-millon martin-millon commented May 21, 2025

This is a draft for now. I am missing :

  • automatic tests

  • handling of the CosmoInterp class (cosmology class must have a H(z) function to be compatible with the BAO likelihood) (return an error for the moment)

  • r_d computation (instead of sampling from a flat prior). This requires some early physics computation, which depends on omega_b and omega_gamma. This is probably unnecessary if no information from BBN or CMB is provided.(return an error for the moment)

This is tested here: https://github.com/TDCOSMO/7LensMilestone/blob/main/Likelihoods/BAOLikelihood/test_sampling_DESI_DR2.ipynb

It reproduces the DESI DR2 results in w0waCDM, in combination with Pantheon+.

@martin-millon martin-millon requested a review from sibirrer May 21, 2025 13:46
@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (38e5159) to head (03e0655).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   99.09%   99.12%   +0.03%     
==========================================
  Files          51       54       +3     
  Lines        2752     2848      +96     
==========================================
+ Hits         2727     2823      +96     
  Misses         25       25              
Files with missing lines Coverage Δ
hierarc/Likelihood/BAOLikelihood/bao_likelihood.py 100.00% <100.00%> (ø)
.../Likelihood/BAOLikelihood/bao_likelihood_custom.py 100.00% <100.00%> (ø)
hierarc/Likelihood/BAOLikelihood/desi_dr2.py 100.00% <100.00%> (ø)
hierarc/Likelihood/cosmo_likelihood.py 96.49% <100.00%> (+0.45%) ⬆️
hierarc/Likelihood/hierarchy_likelihood.py 96.95% <100.00%> (ø)
hierarc/Likelihood/transformed_cosmography.py 100.00% <ø> (ø)
hierarc/Sampling/ParamManager/cosmo_param.py 100.00% <100.00%> (ø)
hierarc/Sampling/ParamManager/param_manager.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @martin-millon. I have a minor comment and hope the tests can be improved

@martin-millon
Copy link
Collaborator Author

@sibirrer, this is ready to be merged (with the caveat that you have to sample r_d and that CosmoInterp can't be used).

Copy link
Owner

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @martin-millon !

@sibirrer sibirrer merged commit 1461bf6 into sibirrer:main May 22, 2025
4 checks passed
@martin-millon martin-millon deleted the BAO-martin branch May 22, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants