Change to use actual language code for directory#12
Open
mnh48 wants to merge 1 commit intosibermerdeka:mainfrom
Open
Change to use actual language code for directory#12mnh48 wants to merge 1 commit intosibermerdeka:mainfrom
mnh48 wants to merge 1 commit intosibermerdeka:mainfrom
Conversation
- changed the directory for pages written in Malay from `bm` to `ms` to follow ISO 639 set 1 tags instead of using abbreviation of the language (bm is abbreviation of bahasa melayu / malaysia) - changed the links and cookie setting to use `ms` instead of `bm` - also added language tag to the HTML pages so that browser and screen readers would know what language the page is written in
Author
|
Also, this one is just a note Potential new languages to add if we have the mean to write them (given our member demographics)
but these would be done separately and only when we're committed to maintaining the translations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in real life yesterday, I've now made changes to use actual language code for directory
bmtomsto follow ISO 639 set 1 tags instead of using abbreviation of the language (bm is abbreviation of bahasa melayu / malaysia)msinstead ofbmThese changes will also make it easier to add more languages in the future when we set the precedence to use ISO language tags instead of coming up with our own directory names