Repository navigation
fix(S028): restore CI and improve current documentation - #98
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
…nance Co-authored-by: Codex <noreply@openai.com>
h8rt3rmin8r
added
type: bug
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
@codex security review Second and final authorized review round for S028 on b733e87. The automatic code review completed without posted findings. Please review the lease qualification, static documentation/export changes, and isolated headless browser/server tooling for security issues. No further review round will be requested. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b733e87c71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
This was referenced Oct 15, 2026
h8rt3rmin8r
added a commit
that referenced
this pull request
Oct 15, 2026
The prepared v1.0.1 changelog snapshot omitted recent merged work, archived v1.0.0 documentation still claimed it was unpublished, and the release workflow lacked PR documentation qualification parity. This finalizes the existing 1.0.1 cut, renders truthful released archive text without changing historical source, and requires site tests plus actual diagram/headless UI qualification before release documentation archival. Tracks #97. **#97 stays open through post-merge release and deployed-documentation verification.** This preparation PR has no closing issue reference. Spec Kit: [S029 artifacts](https://github.com/shruggietech/insonic/tree/ca2e55ffb89ce8d48e36ffaad3886a8cb2611c56/specs/029-v1-0-1-release-publication). Milestone: Documentation quality and v1.0.1 publication. Software, documentation, packages and master schema remain synchronized at 1.0.1. Pre-merge acceptance (T013–T015) is complete: - Final head: `ca2e55ffb89ce8d48e36ffaad3886a8cb2611c56`. [CI run 38680152077](https://github.com/shruggietech/insonic/actions/runs/38680152077) passed all 18 elected jobs; 14 skipped jobs are the expected verified-cache/runtime/package alternatives. - Whole workflow turnaround: **621 seconds (10m21s)**, 2026-10-15 04:11:21–04:21:42 UTC, including three seconds before the first jobs started. This satisfies the 660-second target. - Exact CI merge-source: `76a246465132475ba8314d7f40f54fa491dd619e`, whose parents are base `3abbe8e` and final head `ca2e55f`. Collection qualified four Windows/Linux CLI/Desktop archives, the selectable Windows MSI and both documentation bundles with clean-source inventories, notices/sources, hashes and explicit unsigned disposition. - Repository/schema/brand checks, 103 root tests, 10 site tests and 246 Python tests passed. Local snapshot and release-target public/offline builds, actual Mermaid rendering and headless audits passed. Each audit covered 225 HTML files, 70 width/theme combinations and 18 cases; the final wording correction was rebuilt afterward. - Final-head hosted documentation verification passed all 225 HTML files and 18 cases in 119.7 seconds, with zero external requests/WebSockets/browser errors and verified owned cleanup. The actual WebSocket probe was blocked before any server connection/upgrade/traffic. Historical docs/schemas, governed kit bytes and all screenshot assets/receipts remain unchanged. Native installer/account/UI checks ran only on disposable hosted Windows. - Exactly two review rounds completed on `778f7cc`. The opening review's [heading finding](#99 (comment)) was [answered with exact-source and rendered-HTML evidence](#99 (comment)) and resolved as already satisfied. The [second and final request](#99 (comment)) completed with [no major issues](#99 (comment)). It is labeled Code Review despite the security-focused request; no separate security verdict is claimed. No third request was sent. The final commit changes only release wording and delivery records. - Final paginated review audit found zero unresolved threads or additional review pages. GitHub reports the PR clean and mergeable. The source checklist is a pre-CI snapshot; this PR records completion of its post-commit T015 gate. Earlier CI attempts were superseded for a verified default-branch cache reuse run and then the final release-wording commit. The exact Windows cache key was unchanged; its previously available cache was scoped to PR #98. No qualification was removed or weakened. Existing version-preparation no-overwrite, trusted-main/tag/source, complete native/package, draft/hash and Pages guards remain intact. Automated Chromium and visual checks do not certify screen readers, other engines or complete WCAG conformance; qualification does not establish acoustic accuracy. **Ready for owner final review and squash merge.** T016–T019 remain pending under the owner's existing post-merge authorization: select the exact reviewed squash-main source, freshly qualify release-target packages/docs, create the matching v1.0.1 tag, publish the independently verified complete draft, and promote its original documentation archive through existing Pages to insonic.io. Verify official downloads/digests, exact deployment/source markers, current/archive/schema routes and mobile navigation before completing #97. No merge, tag, official release or deployment has been performed. These PR-source artifacts must not be relabeled as the later squash-main release. --------- Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main CI failed when a real 100ms lease expired before its exclusion assertion, and documentation visitors could reach stale version entry points or a large mobile link cloud. This restores deterministic real-backend fencing qualification, applies the approved 11-minute CI window, and adds full static current-documentation routes with explicit version archives. Shared article/reference navigation now uses native disclosures, readable responsive layouts and usable keyboard/offline fallbacks. The README company attribution links to ShruggieTech.
Closes #93. Closes #94. Closes #95. Closes #96.
Spec Kit artifacts: S028. Milestone: Documentation quality and v1.0.1 publication. Software, documentation and schema remain the 1.0.1 candidate.
Validation passed: repository integrity/schema and brand checks, all 102 root JavaScript tests, 246 Python tests, Go acceptance/vet on Windows and Linux, alternative-backend fixtures, public/offline site builds and actual light/dark Mermaid rendering. The headless standards audit covers 225 HTML pages and 70 representative width/theme combinations, keyboard navigation, no-JavaScript offline reading, storage denial, enlarged/text-spaced reading and forced colors. Both the real WebSocket isolation probe and export symlink/junction regressions pass. Four application figures were refreshed from clean compiled source; governed screenshot receipts and export parity pass. Native installer/account/UI checks ran only on disposable hosted CI.
Final acceptance (T026) is complete:
32c6ed9c7e956f63dd877c47842526be1a798c5d.8b37e4cd22fae925c4e743b8c07943823d15fb88. Candidate collection verified four Windows/Linux archives, the Windows MSI, public documentation and offline help against this source, with clean-source receipts. This CI candidate has not been published as a release.dca1093, answered and resolved; a final paginated audit found no open threads. No separate security-review verdict is claimed and no third review was requested.Automated Chromium and captured visual checks do not certify screen readers, other engines or complete WCAG conformance. Deployed-site behavior is not claimed from source exports.
Ready for owner final review and squash merge. #97 remains Backlog / Unassigned for after merge. No merge, tag, release or deployment has been performed. Release/site publication must qualify the resulting squash-main revision rather than relabel these PR-source artifacts.