Repository navigation
fix(S030): harden release bootstrap and verify public deployments - #104
Conversation
Acquire locked setup actions in bounded steps, preserve upstream cache hooks and historical workflow tooling, and verify original release documentation over public HTTPS after exact Pages deployment. Co-authored-by: Codex <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Add an owned-connection watchdog and a failing-then-passing stalled-header regression. Preserve retry limits, verified identities and all qualification gates. Co-authored-by: Codex <noreply@openai.com>
|
Second and final authorized review round (2 of 2). The opening review completed clean with a bot thumbs-up and zero inline threads. The latest commit adds an owned-connection deadline watchdog plus a failing-then-passing stalled-header regression; all 279 Python tests and the complete read-only live verifier pass (9 original assets, 290 live URLs/212 files, exact existing Pages commit). Please review the current head for code and security findings. No further review round will be triggered. |
|
Security portion of the same final review round (2 of 2), for head @codex security review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1404e4853f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Check the complete original export and resolved HTML/CSS dependencies. Run network work in one hidden parent-bounded worker per acquisition or public batch, with owned-child timeout cleanup and no inherited GitHub credentials. Resolve both final-round review findings with regressions and full local parity. Co-authored-by: Codex <noreply@openai.com>
|
S030 is ready for owner final review and squash merge. Final head:
Issues #102/#103 acceptance is checked and their Project state remains In review until merge. This comment records final Spec Kit delivery task T013 acceptance after publication, avoiding an evidence-only commit and another CI run. The checkout is clean and synchronized. No release, tag or site deployment was changed. PR checks do not establish the later squash commit's main-branch CI; that must be verified after merge. |
Pinned setup-go downloads have failed during runner preparation, before a build-step retry could run. This change acquires the existing Go/Node action revisions in bounded, SHA256-verified steps, then executes their complete upstream trees locally with the same inputs and cache post hooks. Historical candidates obtain bootstrap tooling from the defining workflow commit; matching source/workflow revisions reuse the existing checkout.
It also adds
release.py verify-publicand runs it after exact Pages promotion. The GET-only verifier checks the original candidate, published tag/source and full asset metadata, compares archived documentation with actual public navigation/resource URLs, and fences the Pages commit before and after live reads. Public binary API metadata proof is reported separately from downloaded documentation byte proof.Closes #102
Closes #103
Validation: 104 root tests, 284 Python tests, 10 site tests, repository/schema/brand checks and public/offline site exports passed locally. The actual read-only CLI verified all nine original v1.0.1 assets, full published metadata and 891 live URLs covering all 813 original export files in 41.515 seconds, with exact existing Pages commit
85b1476d86a9bfe8fbaac159b4df98226bc2393a. No release/tag/deployment was changed. Spec Kit artifacts and evidence:specs/030-release-pipeline-reliability/.Hosted Windows/Linux qualification and exact-head CI remain required. Limits: three acquisition attempts/60 seconds per action; 120-second public content phase. Checkout/other action preparation still depends on GitHub. Archive compression changes require reviewed lock refresh; the lock needs explicit maintenance outside normal Dependabot action discovery.
Owner final review and squash merge follow green CI and resolved reviews. No new product release is requested by this PR.
Final-round findings addressed in
0aeded2: include all original export files and resolved CSS/font dependencies, and bound DNS/connection/TLS/body work through a parent-owned hidden network worker (one four-thread worker per public batch). Both inline findings have replies and are resolved. No further review request will be made; final-head CI remains the delivery gate.