fix: validate passphrase on empty-vault unlock (prevent lockout)#884
fix: validate passphrase on empty-vault unlock (prevent lockout)#884saurabhhhcodes wants to merge 1 commit into
Conversation
🚀 Thank You for Contributing to Late-MeetPlease ensure that:
Thank you for contributing 💙 |
|
👋 Thank you @saurabhhhcodes for your contribution to Late-Meet! Please review any automated suggestions or code review comments that may appear below! We will review your PR as soon as possible! Please consider starring the repository ⭐ to show your support! |
|
Warning Review limit reached
Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
🔔 Friendly ping @shouri123 — this real fix has passing CI and references an approved GSSoC issue. Ready for review/merge. Thanks! |
1 similar comment
|
🔔 Friendly ping @shouri123 — this real fix has passing CI and references an approved GSSoC issue. Ready for review/merge. Thanks! |



Real fix for #837.
unlockCredentials()accepted any passphrase when the vault was initialized (salt present) but empty (no verification token and no credentials), caching the wrong derived key and permanently locking the user out on the next save. Now the unlock path validates against a persisted verification token; a partially-initialized vault auto-creates that token so future unlocks are verifiable. Adds a regression test.Closes #837