Skip to content

fix: validate passphrase on empty-vault unlock (prevent lockout)#884

Open
saurabhhhcodes wants to merge 1 commit into
shouri123:mainfrom
saurabhhhcodes:fix/837-vault-empty-unlock
Open

fix: validate passphrase on empty-vault unlock (prevent lockout)#884
saurabhhhcodes wants to merge 1 commit into
shouri123:mainfrom
saurabhhhcodes:fix/837-vault-empty-unlock

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Real fix for #837.

unlockCredentials() accepted any passphrase when the vault was initialized (salt present) but empty (no verification token and no credentials), caching the wrong derived key and permanently locking the user out on the next save. Now the unlock path validates against a persisted verification token; a partially-initialized vault auto-creates that token so future unlocks are verifiable. Adds a regression test.

Closes #837

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Thank You for Contributing to Late-Meet

Please ensure that:

  • the issue was assigned to you before opening this PR
  • the PR references the related issue
  • your changes follow repository contribution guidelines
  • the project builds successfully before submission

Unassigned, duplicate, or low-quality PRs may be closed.

Thank you for contributing 💙

@github-actions github-actions Bot added gssoc Official GSSoC contribution issue gssoc:approved GSSoC: PR approved and scored type:code Type: Code change type:test Type: Test files security-review Requires security review before merge bug Something isn't working size/M unassigned-pr labels Jul 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you @saurabhhhcodes for your contribution to Late-Meet!

⚠️ Warning: You are not currently assigned to the linked issue #837. Please request assignment on that issue before submitting a PR.

Please review any automated suggestions or code review comments that may appear below! We will review your PR as soon as possible!


Please consider starring the repository ⭐ to show your support!

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@saurabhhhcodes, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0abb2708-5a9c-4950-b5d2-3f75170b2da8

📥 Commits

Reviewing files that changed from the base of the PR and between d216444 and 8f3fc47.

📒 Files selected for processing (2)
  • src/utils/credentials.test.ts
  • src/utils/credentials.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@saurabhhhcodes

Copy link
Copy Markdown
Author

🔔 Friendly ping @shouri123 — this real fix has passing CI and references an approved GSSoC issue. Ready for review/merge. Thanks!

1 similar comment
@saurabhhhcodes

Copy link
Copy Markdown
Author

🔔 Friendly ping @shouri123 — this real fix has passing CI and references an approved GSSoC issue. Ready for review/merge. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gssoc:approved GSSoC: PR approved and scored gssoc Official GSSoC contribution issue security-review Requires security review before merge size/M type:code Type: Code change type:test Type: Test files unassigned-pr

Projects

None yet

1 participant