Skip to content

fix: guard participantNameFromCandidate against nullish candidate#878

Open
saurabhhhcodes wants to merge 1 commit into
shouri123:mainfrom
saurabhhhcodes:fix/803-participant-null-candidate
Open

fix: guard participantNameFromCandidate against nullish candidate#878
saurabhhhcodes wants to merge 1 commit into
shouri123:mainfrom
saurabhhhcodes:fix/803-participant-null-candidate

Conversation

@saurabhhhcodes

@saurabhhhcodes saurabhhhcodes commented Jul 20, 2026

Copy link
Copy Markdown

Real fix for #803.

Make participantNameFromCandidate null-safe so a nullish candidate no longer throws a TypeError on property access; adds a regression test.

Closes #803

Summary by CodeRabbit

  • Bug Fixes

    • Improved participant name handling when candidate information is missing.
    • Prevented errors caused by null or undefined participant data.
  • Tests

    • Added coverage verifying safe handling of missing participant information.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Thank You for Contributing to Late-Meet

Please ensure that:

  • the issue was assigned to you before opening this PR
  • the PR references the related issue
  • your changes follow repository contribution guidelines
  • the project builds successfully before submission

Unassigned, duplicate, or low-quality PRs may be closed.

Thank you for contributing 💙

@github-actions github-actions Bot added gssoc Official GSSoC contribution issue gssoc:approved GSSoC: PR approved and scored bug Something isn't working size/S unassigned-pr type:code Type: Code change type:test Type: Test files and removed unassigned-pr labels Jul 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you @saurabhhhcodes for your contribution to Late-Meet!

⚠️ Warning: You are not currently assigned to the linked issue #803. Please request assignment on that issue before submitting a PR.

Please review any automated suggestions or code review comments that may appear below! We will review your PR as soon as possible!


Please consider starring the repository ⭐ to show your support!

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e843dd40-5d13-4321-b056-51f5f87c9af9

📥 Commits

Reviewing files that changed from the base of the PR and between d216444 and ff978a8.

📒 Files selected for processing (2)
  • src/participantDetection.test.ts
  • src/participantDetection.ts

📝 Walkthrough

Walkthrough

participantNameFromCandidate now accepts nullish candidates, returns null without property access, and has tests for both null and undefined.

Changes

Participant detection safety

Layer / File(s) Summary
Nullish candidate guard and coverage
src/participantDetection.ts, src/participantDetection.test.ts
participantNameFromCandidate accepts null and undefined, returns null for either input, and tests verify both cases.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: shouri123

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: guarding participantNameFromCandidate against nullish input.
Linked Issues check ✅ Passed The code adds the requested null/undefined guard and regression test for issue #803.
Out of Scope Changes check ✅ Passed All changes are directly related to the nullish-input guard and its regression test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@saurabhhhcodes

Copy link
Copy Markdown
Author

🔔 Friendly ping @shouri123 — this real fix has passing CI and references an approved GSSoC issue. Ready for review/merge. Thanks!

1 similar comment
@saurabhhhcodes

Copy link
Copy Markdown
Author

🔔 Friendly ping @shouri123 — this real fix has passing CI and references an approved GSSoC issue. Ready for review/merge. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gssoc:approved GSSoC: PR approved and scored gssoc Official GSSoC contribution issue size/S type:code Type: Code change type:test Type: Test files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Make participantNameFromCandidate safe against null/undefined inputs

1 participant