Skip to content

fix: add aria-labels to icon-only buttons for accessibility #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Siddh2024 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add aria-labels to icon-only buttons for accessibility #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/options.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,11 @@ <h2 class="section-title">
<p class="form-hint">Required for AI summarization</p>
<div class="input-row">
<input type="password" id="openai-key" class="form-input" placeholder="sk-..." />
<button class="toggle-vis" data-target="openai-key">
<button
class="toggle-vis"
data-target="openai-key"
aria-label="Toggle API key visibility"
>
<svg
xmlns="http://www.w3.org/2000/svg"
width="16"
Expand All @@ -188,7 +192,11 @@ <h2 class="section-title">
<p class="form-hint">Required for Speech-to-Text transcription</p>
<div class="input-row">
<input type="password" id="elevenlabs-key" class="form-input" placeholder="sk_..." />
<button class="toggle-vis" data-target="elevenlabs-key">
<button
class="toggle-vis"
data-target="elevenlabs-key"
aria-label="Toggle API key visibility"
>
<svg
xmlns="http://www.w3.org/2000/svg"
width="16"
Expand Down
8 changes: 6 additions & 2 deletions src/popup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ <h1 class="setup-title">Initialize Copilot</h1>
<label class="setup-label">OpenAI API Key</label>
<div class="input-group">
<input type="password" id="api-key-input" class="setup-input" placeholder="sk-..." />
<button id="toggle-key" class="toggle-btn">👁</button>
<button id="toggle-key" class="toggle-btn" aria-label="Toggle API key visibility">
👁
</button>
</div>

<button id="save-keys" class="setup-btn">
Expand Down Expand Up @@ -81,7 +83,9 @@ <h1 class="setup-title">Initialize Copilot</h1>
</div>
</div>
</div>
<button id="settings-btn" class="icon-btn" title="Settings">⚙️</button>
<button id="settings-btn" class="icon-btn" title="Settings" aria-label="Settings">
⚙️
</button>
</header>

<!-- Content Sections -->
Expand Down