Skip to content

fix: add missing @keyframes shake animation#867

Open
Siddh2024 wants to merge 1 commit into
shouri123:mainfrom
Siddh2024:fix/529-shake-keyframes
Open

fix: add missing @keyframes shake animation#867
Siddh2024 wants to merge 1 commit into
shouri123:mainfrom
Siddh2024:fix/529-shake-keyframes

Conversation

@Siddh2024

@Siddh2024 Siddh2024 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #529 - adds the @Keyframes shake CSS rule referenced by shakeElement() in popup.ts

Summary by CodeRabbit

  • Style
    • Added a subtle shake animation that can be used by popup interface elements.

@Siddh2024
Siddh2024 requested a review from shouri123 as a code owner July 11, 2026 12:28
The shakeElement() function in popup.ts references a 'shake' animation
but the corresponding @Keyframes rule was never defined. This causes
the shake feedback animation to not play when users submit invalid
input.

Fixes shouri123#529
@github-actions github-actions Bot added gssoc Official GSSoC contribution issue gssoc:approved GSSoC: PR approved and scored labels Jul 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Thank You for Contributing to Late-Meet

Please ensure that:

  • the issue was assigned to you before opening this PR
  • the PR references the related issue
  • your changes follow repository contribution guidelines
  • the project builds successfully before submission

Unassigned, duplicate, or low-quality PRs may be closed.

Thank you for contributing 💙

@github-actions github-actions Bot added bug Something isn't working size/S labels Jul 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you @Siddh2024 for your contribution to Late-Meet!

✅ Verified: You are assigned to the linked issue #529.

Please review any automated suggestions or code review comments that may appear below! We will review your PR as soon as possible!


Please consider starring the repository ⭐ to show your support!

@github-actions github-actions Bot added type:style Type: CSS/Styling change and removed bug Something isn't working size/S labels Jul 11, 2026
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e129ba82-7d7e-42b6-a9b6-4a8ed0f7b713

📥 Commits

Reviewing files that changed from the base of the PR and between d216444 and c180ac0.

📒 Files selected for processing (1)
  • src/popup.css

📝 Walkthrough

Walkthrough

Adds the missing shake CSS animation to src/popup.css, defining horizontal translations at intermediate keyframes and returning to the original position.

Changes

Popup feedback

Layer / File(s) Summary
Define popup shake animation
src/popup.css
Adds @keyframes shake with left-right translateX transitions from 0px to -5px, then +5px, and back to 0px.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding the missing shake animation.
Linked Issues check ✅ Passed The change adds the missing @keyframes shake rule in popup.css, matching issue #529 and restoring invalid-input feedback.
Out of Scope Changes check ✅ Passed The PR stays focused on the missing shake animation and introduces no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved and scored gssoc Official GSSoC contribution issue type:style Type: CSS/Styling change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] @keyframes shake animation referenced in popup.ts but never defined anywhere

1 participant