Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip minification in order to allow the post job to run on self-hosted runners as well #68

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

philipreinken
Copy link
Contributor

@philipreinken philipreinken commented Jan 29, 2025

We currently encounter problems when including this action on self-hosted runners; the post job crashes when cache restoration is impossible.

Multiple references exist to similar problems when code minification and the JS actions SDK are used (see commit message).

I was able to fix the build using this branch:

I'm aware that removing minification is not the best solution, but bun doesn't yet take the esbuild --keep-names flag into account, so this is the only way that I know of to fix this.

@philipreinken philipreinken requested a review from shyim January 29, 2025 09:44
@philipreinken philipreinken self-assigned this Jan 29, 2025
@shyim shyim merged commit c20ea3f into main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants