Further fix for seed crypto things #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you @R-YaTian :) |
Contributor
Author
Owner
|
No problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a further work of the previous PR. It creates a reversed copy of
header.titleidand passes it to theparse_ncchfunction, preventingheader.titleidfrom being reversed multiple times. This avoids incorrect data whenparse_ncchinternally readsheader.titleid, ensuring the correct retrieval of theSeed Crypto KeyYwhen processing multiple NCCH contents.Additionally, this PR fixes a potential issue with incorrect parsing of
titleid[3], preventing possible decryption errors for system applications (0004001x).Edit: The PR which do similar fix for old python3 version will be opened later on. :p
Edit x2: This PR will fix issue #7.