Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic improvements for suggestion email helper on add/edit form #869

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Semantic improvements for suggestion email helper on add/edit form #869

wants to merge 2 commits into from

Conversation

carrythebanner
Copy link
Collaborator

@carrythebanner carrythebanner commented Feb 18, 2025 •
edited
Loading

  • Use proper semantic buttons for email suggestion (previously, suggestion "buttons" were clickable but not keyboard-focusable)
  • Use aria-live announcement when suggestion appears

@carrythebanner carrythebanner marked this pull request as ready for review February 18, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carrythebanner