Skip to content

Fix: verify transactionId mismatch for Saman payment driver (Related to shetabit/payment#351) #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ham1dRz wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −1
Open

Fix: verify transactionId mismatch for Saman payment driver (Related to shetabit/payment#351) #331

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0987672
Fix: incorrect transactionId for verification in purchase callback fo…
Ham1dRz Sep 27, 2025
a56ff3f
Refactor: use data['ResNum'] for better readability (Related to sheta…
Ham1dRz Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Drivers/Saman/Saman.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function purchase()
$this->invoice->transactionId($response);
Copy link
Member

@khanzadimahdi khanzadimahdi Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please set resnum in the transaction id if it is used to verify the payment

Copy link
Member

@khanzadimahdi khanzadimahdi Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is not valid. you need to set transaction id and then return in in the purchase method and then user can rely on it to verify the payment.

Copy link
Member

@khanzadimahdi khanzadimahdi Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to fix the line 86 in the purchase method instead of this line.


// return the transaction's id
return $this->invoice->getTransactionId();
return $this->invoice->getUuid();
}

/**
Expand Down