Helga 2.0 / Python3 upgrade #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cause they're both available on whatever the current python:3 image i'm using will fix this later ;)
See PEP 479, StopIteration is now a RunTimeError [1] - https://www.python.org/dev/peps/pep-0479/
|
@shaunduncan would you mind adding @bigjust as a co-maintainer so he has access to merge and upload to PyPI? |
|
I can! And I have not a single clue how I missed seeing this PR, but amazing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to Python 3.7+
Tests pass for Python 3.7 and 3.8 and working docker image. running
docker buildwill run unit tests anddocker-compose upwill spin up a working helga+mongodb as well as an irc server.Could document the Dockerfile a bit more, but the settings are relatively straightforward. I extend it like this: https://github.com/bigjust/nintenbots/blob/master/docker/aineko/Dockerfile.
I've tested a number of plugins (after upgrading them for py3) and things seem to be working. Tested only on IRC (local + freenode).