Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints via JSON schemas for themes/*.yml and config/filetypes.yml #130

Merged

Conversation

EmilyGraceSeville7cf
Copy link
Contributor

No description provided.

@EmilyGraceSeville7cf
Copy link
Contributor Author

@sharkdp, can you review this PR?

@sharkdp
Copy link
Owner

sharkdp commented Apr 2, 2024

Thank you. Can you go into a little bit of detail as to what this allows developers to do?

@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented Apr 4, 2024

Thank you. Can you go into a little bit of detail as to what this allows developers to do?

It allows developers to validate themes/*.yml themes in the following way:

  • incorrect key types and their values are reported as errors
  • possible common color names are suggested
  • possible common file category names are suggested
  • .etc

image

image

image

The same applies for filetypes.yml: it's also validated.

image

Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@sharkdp sharkdp merged commit e06fd14 into sharkdp:master Apr 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants