Skip to content

Visvalingam runs on both 64 and 32 floats. #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Visvalingam runs on both 64 and 32 floats. #169

wants to merge 2 commits into from

Conversation

@justoruiz
Copy link
Member

Description

Visvalingam now runs transparently for float64 and float32 types.

Tests

Added DimensionalityTests.VisvalingamAF to test both scenarios.

Benchmarks

N/A

@justoruiz justoruiz requested a review from daniram9 September 2, 2021 21:32
@justoruiz justoruiz self-assigned this Sep 2, 2021
daniram9
daniram9 previously approved these changes Sep 3, 2021
View reviewed changes
@justoruiz justoruiz marked this pull request as draft September 3, 2021 09:01
@justoruiz justoruiz marked this pull request as ready for review September 3, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@daniram9 daniram9 daniram9 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@justoruiz justoruiz

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justoruiz @daniram9