Skip to content

Fix Redux generator creating unnecessary CSS in ror_components directory #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Fix Redux generator creating unnecessary CSS in ror_components directory #1826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06b0dd5
Fix Redux generator creating unnecessary CSS in ror_components directory
ihabadham Sep 25, 2025
45adfd2
Add test coverage for Redux generator directory isolation
ihabadham Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/install_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def invoke_generators
create_css_module_types
create_typescript_config
end
invoke "react_on_rails:base", [], { typescript: options.typescript? }
invoke "react_on_rails:base", [], { typescript: options.typescript?, redux: options.redux? }
if options.redux?
invoke "react_on_rails:react_with_redux", [], { typescript: options.typescript? }
else
Expand Down
5 changes: 5 additions & 0 deletions spec/react_on_rails/support/shared_examples/react_with_redux_generator_examples.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,9 @@
app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.client.jsx
app/javascript/src/HelloWorldApp/ror_components/HelloWorldApp.server.jsx].each { |file| assert_file(file) }
end

it "does not create non-Redux HelloWorld ror_components directory" do
assert_no_directory "app/javascript/src/HelloWorld/ror_components"
assert_no_file "app/javascript/src/HelloWorld/ror_components/HelloWorld.module.css"
end
end
Loading