Skip to content

Conversation

@chescalante
Copy link

Hi @shahnawaz, I'm sending you this pull request with changes for adapting the package for hooks.

Highlights:

  1. Component props are now deconstructed in the component function definition. I believe this way is more readable and easy to change.
  2. defaultProps it is now removed, it can be placed directly when the props are deconstructed. Same benefits as in 1.
  3. I took componentDidMount, componentWillUnmount, _startLineAnimation and _animateLoop and replaced it with useEffect: allowing start and re-start an animation when parameters change or when the component is mounted.

Let me know what you think

@shahnawaz
Copy link
Owner

Hi @chescalante

Thank you for this amazing update.

I'll review and get back to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants