Adding colors to indicate day/night in clock#1593
Open
Mats391 wants to merge 4 commits intoshagu:masterfrom
Open
Adding colors to indicate day/night in clock#1593Mats391 wants to merge 4 commits intoshagu:masterfrom
Mats391 wants to merge 4 commits intoshagu:masterfrom
Conversation
Contributor
Author
|
I also thought about adding a small sun and moon next to it, but couldnt figure out how. |
Contributor
Author
|
Updated the blue color to have more contrast |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wanted to go Nightfinsnapper fishing and didnt know when it was day or night. So I added the day/night indication to the clock through some colors. Day is orange, blue is night.
I added no option to enable/disable this. Let me know if this is needed or if colors should be adjusted for contrast etc.