Skip to content

Conversation

@yannickwellens
Copy link

No description provided.

@shagu
Copy link
Owner

shagu commented Jun 8, 2025

Hello, thanks for your contribution. 🚀

Has this been tested with all the other options? I feel like there's a huge potential of conflicts with other health offsets and options that hide the healthbar. Please also remove the font as this doesn't seem to be it should be part of the PR, and double check your formatting, you have added some trailing whitespaces and empty lines that aren't needed.

When that is resolved and if you say this is stable and has gone through a good amount of testing, I will be happy to merge it.

@yannickwellens
Copy link
Author

yannickwellens commented Jun 9, 2025

I didn't add the font in this one yet :).

Any chance you can give me a list to start off with to test :D. As you know the code inside and out. I indeed just looked at my usecase. Works great so far (including zoom on target, hiding friendly/enemy, etc.).

Also feel free to test it out yourself, I will of course make changes to the code if a bug arises!

@shagu
Copy link
Owner

shagu commented Jun 9, 2025

I didn't add the font in this one yet :).

You did:
image

Any chance you can give me a list to start off with to test :D. As you know the code inside and out. I indeed just looked at my usecase. Works great so far (including zoom on target, hiding friendly/enemy, etc.).

Vertical offset of the nameplate, vertical offset of the healthbar. Checking if the castbar, combopoints and debuffs are still aligned. Same with the "hidden" ones (like on critters or friendly NPCs). Cheking the Totem Icons too. Those would be the ones I think of at first.

Also feel free to test it out yourself, I will of course make changes to the code if a bug arises!

I don't have much time to spend today and don't want to spend my time on a early snapshot of someone else.
I have enough things on my "plate" that I want to work on - I spent way to much time in the past pulling commits that are at best an early WIP, but titled as "ready". When you say this is ready, you did your testing and you're confident with the code - I will start my tests.

@yannickwellens
Copy link
Author

yannickwellens commented Jun 11, 2025

My apologies, was testing stuff out. Indeed Added the font, will fix that, as the other comments.

I don't have time also to test this out with work, but I'll let you know.

So far vertical offset, debuffs, hidden stuff, all good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants