-
Notifications
You must be signed in to change notification settings - Fork 166
Added necessary changes to support name and level offset #1515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added necessary changes to support name and level offset #1515
Conversation
|
Hello, thanks for your contribution. 🚀 Has this been tested with all the other options? I feel like there's a huge potential of conflicts with other health offsets and options that hide the healthbar. Please also remove the font as this doesn't seem to be it should be part of the PR, and double check your formatting, you have added some trailing whitespaces and empty lines that aren't needed. When that is resolved and if you say this is stable and has gone through a good amount of testing, I will be happy to merge it. |
|
I didn't add the font in this one yet :). Any chance you can give me a list to start off with to test :D. As you know the code inside and out. I indeed just looked at my usecase. Works great so far (including zoom on target, hiding friendly/enemy, etc.). Also feel free to test it out yourself, I will of course make changes to the code if a bug arises! |
Vertical offset of the nameplate, vertical offset of the healthbar. Checking if the castbar, combopoints and debuffs are still aligned. Same with the "hidden" ones (like on critters or friendly NPCs). Cheking the Totem Icons too. Those would be the ones I think of at first.
I don't have much time to spend today and don't want to spend my time on a early snapshot of someone else. |
|
My apologies, was testing stuff out. Indeed Added the font, will fix that, as the other comments. I don't have time also to test this out with work, but I'll let you know. So far vertical offset, debuffs, hidden stuff, all good :) |
…b.com/yannickwellens/pfUI into feat/yannickwellens/name_level_offset

No description provided.