fix(button): add aria-invalid border for all variants #8999
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes shadcn-ui#8920 The Button component had aria-invalid styling in its base classes (ring and border-destructive) but only the outline variant had a visible border. Other variants (default, secondary, ghost, destructive, link) showed no visual feedback when aria-invalid was set. Added `aria-invalid:border` to make the border visible on all variants when the button is marked as invalid.
|
@nathannewyen is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
aria-invalid:borderto Button component base stylesFixes #8920
Description
The Button component had
aria-invalid:border-destructivein its base classes, but this only worked for theoutlinevariant which already has aborderclass. Other variants (default, secondary, ghost, destructive, link) showed no visual feedback whenaria-invalidwas set.Before: Only outline variant showed red border on aria-invalid
After: All variants show red border on aria-invalid
Changes
Added
aria-invalid:borderbeforearia-invalid:border-destructivein:apps/v4/registry/new-york-v4/ui/button.tsxtemplates/monorepo-next/packages/ui/src/components/button.tsxTesting
Tested all button variants with
aria-invalidattribute: