Fix(sidebar): /issue 8975 sidebar lg collapse #8984
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Hamed-Ajaj is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Hamed-Ajaj
force-pushed
the
fix/issue-8975-sidebar-lg-collapse
branch
from
650ae65 to
e8917ea
Compare
Hamed-Ajaj
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8975
This PR fixes the issue where
SidebarMenuButtonwithsize="lg"doesn't properly collapse to icon-only mode when the sidebar is incollapsible="icon"state.Changes
group-data-[collapsible=icon]:size-8!to thelgsize variant insidebarMenuButtonVariantsgroup-data-[collapsible=icon]:p-0!Before
When sidebar was collapsed,
size="lg"buttons retained their 48px height and text remained visible.After
size="lg"buttons now properly collapse to 32x32px icon-only mode, with text hidden and tooltip displayed on hover.Testing
size="lg"buttons in collapsed sidebar