-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: shadcn website light/dark toggle broken #6207
Comments
Has anyone been able to successfully reproduce this bug? Even when I use the same Windows 10 and Edge browser, I cannot replicate the bug. |
@ejzeronimo |
@candymask0712 cannot reproduce for myself in MacOs. Chrome. |
Reproduce on Windows 11. Edge and Chrome When the CPU is idle or there is only one tab, it cannot be reproduced When the page flashes, in the Performance tab of DevTools, you will see a loop call to the following two functions
|
Thank you for finding a way to reproduce the bug! I have been trying to reproduce it but have been busy preparing for CES. My bet is this is an issue with next-themes? |
Yes, I can also reproduce it on other websites that use next-themes |
@DALLLLAWEI |
@candymask0712 |
next-themes v0.4.4 has fixed this issue |
@DALLLLAWEI |
An easy way to recreate this is to use a tool like aida64, start a CPU test, then use an autoclicker to rapidly click the theme button while at least 2 tabs are open. I found that swapping to the charts page then switching tabs causes it most of the time. It seems to be doable when the CPU isn't being stressed but it was much less severe. I submitted a PR to bump the next-themes version, huge thanks for finding out the conditions @DALLLLAWEI! |
Describe the bug
I had the docs open then started using the theme toggle on the website to see what certain blocks/components would look like in dark mode. After that I set it back to light mode and stepped away. Then this video happened, please be warned it flashes very fast, so I am wrapping the link that way there is no chance it will auto-play when viewing this issue.
https://github.com/user-attachments/assets/757feda6-8c21-44f6-9f6b-854ec58a698a
Not sure if this is an issue with the site or something weird with next-themes but I figured I would make a bug report here to let you know regardless.
Affected component/components
None, this is the shadcn site
How to reproduce
Go to components page.
Toggle themes ~10 times
Leave on light mode
???
(this was all I did)
Codesandbox/StackBlitz link
No response
Logs
No response
System Info
Before submitting
The text was updated successfully, but these errors were encountered: