You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: replace bg-blue-500 with bg-foreground on mobile nav New dot - #14
The mobile nav "New" dot was the last remaining hardcoded color in the UI — the docs-sidebar dot and sponsor heart were already replaced by the landing redesign. This swaps bg-blue-500 for the bg-foreground theme token in components/mobile-nav.tsx so the dot follows light/dark mode.
Note: styles/globals.css still references --color-blue-500 as the value of the --chart-2 chart-palette token — that is an intentional palette definition, not UI chrome, so I left it untouched.
Verification
pnpm check (ultracite lint/format): exit 0.
pnpm typecheck: exit 0.
pnpm build: exit 0.
No visual browser check (headless environment); the change is a token swap on an 8px dot and bg-foreground is already used in the same file.
Feedback welcome — please contact me at ldcuong11@gmail.com, happy to fix any requested changes.
Summary by CodeRabbit
Style
Changed the mobile navigation’s “New” indicator from blue to the foreground color.
This change makes the mobile navigation "New" dot use the theme foreground color so it follows light and dark mode. It is a one-class cosmetic update with negligible risk and is ready to merge.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the actual change: the mobile nav "New" dot's bg-blue-500 is replaced with the bg-foreground theme token. This matches the single-file change in components/mobile-nav.tsx and the linke…
Description check
The description covers the core content. It links the issue (Fixes #7) and explains the problem and the fix, including the intentional leftover --color-blue-500 in globals.css. It lists verification c…
Linked Issues check
Issue #7 asks to remove the remaining colored site chrome: the docs-sidebar "New" dot, the mobile-nav "New" dot, and the sponsor heart. At the reviewed head (c44f5c6): - Mobile-nav dot (this PR): `com…
Out of Scope Changes check
The whole-PR diff against merge base 4425c29 changes one line in components/mobile-nav.tsx: the "New" dot class changes from bg-blue-500 to bg-foreground. This directly implements the issue #7 o…
Full details: Title check
Explanation
The title names the actual change: the mobile nav "New" dot's bg-blue-500 is replaced with the bg-foreground theme token. This matches the single-file change in components/mobile-nav.tsx and the linked objective for that dot. The title uses the "fix:" prefix, which is a convention choice and does not affect relevance. It is 65 characters, within a normal length.
Full details: Description check
Explanation
The description covers the core content. It links the issue (Fixes #7) and explains the problem and the fix, including the intentional leftover --color-blue-500 in globals.css. It lists verification commands and results and explains why a visual check was not run. It does not follow the template headings exactly: the 'Summary' and 'Validation' headings are missing, and the Checklist section is absent. The author also included a personal contact email, which is not part of the template. The description is mostly complete, so the check passes, but the template structure and checklist should be added.
Full details: Linked Issues check
Explanation
Issue #7 asks to remove the remaining colored site chrome: the docs-sidebar "New" dot, the mobile-nav "New" dot, and the sponsor heart. At the reviewed head (c44f5c6):
Mobile-nav dot (this PR): components/mobile-nav.tsxMobileLink now uses bg-foreground. No bg-blue-500 remains in the file. This matches the issue's proposed token.
Docs-sidebar "New" marker: components/docs-sidebar.tsx renders a "new" pill with bg-brand/15 text-brand. It no longer uses bg-blue-500. This implementation is already present and was not changed by this PR. It uses the theme token --color-brand, which is defined once in styles/globals.css.
Sponsor heart: components/sponsor-link.tsx no longer uses text-pink-500. The button uses BRAND_BUTTON, and HeartHandshakeIcon draws with stroke="currentColor", so the icon takes the button color. The contents of components/landing/button-styles were not inspected.
The issue allows one retained accent if it is defined once as a token and used consistently. The brand family is that shared token. The sidebar and sponsor results use a token that is not the exact example in the issue, but the issue's alternative clause covers this. The mobile-nav dot satisfies the primary proposal directly. Remaining uncertainty: the sponsor color depends on BRAND_BUTTON, which was not inspected.
Full details: Out of Scope Changes check
Explanation
The whole-PR diff against merge base 4425c29 changes one line in components/mobile-nav.tsx: the "New" dot class changes from bg-blue-500 to bg-foreground. This directly implements the issue #7 objective for the mobile-nav dot. The PR does not change styles/globals.css. The --chart-2 token that still references --color-blue-500 is a chart palette definition. It is not UI chrome named in issue #7, and the PR leaves it unchanged as the description states. No unrelated changes were found.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: c860f62f-d2e4-4c1e-b3e6-f699aa013fc0
Commits
Reviewing files that changed from the base of the PR and between 4425c29 and c44f5c6.
Files selected for processing: 1
components/mobile-nav.tsx
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7.
The mobile nav "New" dot was the last remaining hardcoded color in the UI — the docs-sidebar dot and sponsor heart were already replaced by the landing redesign. This swaps
bg-blue-500for thebg-foregroundtheme token incomponents/mobile-nav.tsxso the dot follows light/dark mode.Note:
styles/globals.cssstill references--color-blue-500as the value of the--chart-2chart-palette token — that is an intentional palette definition, not UI chrome, so I left it untouched.Verification
pnpm check(ultracite lint/format): exit 0.pnpm typecheck: exit 0.pnpm build: exit 0.bg-foregroundis already used in the same file.Feedback welcome — please contact me at ldcuong11@gmail.com, happy to fix any requested changes.
Summary by CodeRabbit