Added caching to bson formats generic reader + some default bson readers#47
Open
pchmiele wants to merge 2 commits into
Open
Added caching to bson formats generic reader + some default bson readers#47pchmiele wants to merge 2 commits into
pchmiele wants to merge 2 commits into
Conversation
Contributor
|
Have you tried using |
Author
|
I tried couple different combinations of Lazy/Strict/Cached and this one worked best, but will check if it isn't better. |
Author
|
I didn't played with it long but I didn't saw benefit of usage of shapeless.Cached.implicitly. I would prefer to stick with the change I suggested if it is ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some default bson formats (for optional values - they are used quite often and shapeless is not handling caching them properly)
Added bsonFormat for Seq[T]
Replaced eager evaluation with caching one for generic bson format.
More info about impact on performance here