Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename rust folder to sgl-router #2464

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Rename rust folder to sgl-router #2464

merged 1 commit into from
Dec 12, 2024

Conversation

MrAta
Copy link
Contributor

@MrAta MrAta commented Dec 12, 2024

Motivation

Rename rust folder to sgl-router to be consistent with other sub packages.

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

ByronHsu
ByronHsu approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@ByronHsu ByronHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. can you move "release" from v0.1.0 to readme.md
  2. can you try to bump and publish a new ver to ensure the new structure is ok

@ByronHsu ByronHsu merged commit e3b3acf into sgl-project:main Dec 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronHsu ByronHsu ByronHsu approved these changes

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrAta @ByronHsu