Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged three native APIs into one: get_server_info #2152

Merged
merged 9 commits into from
Nov 24, 2024

Conversation

henryhmko
Copy link
Contributor

Motivation

Merged Native API endpoints get_server_args, get_memory_pool_size, and get_max_num_tokens into one endpoint: get_server_info for cleaner code in server.py.

Modifications

Merged the three endpoints as mentioned above + Updated the docs/unittests accordingly.

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@ByronHsu
Copy link
Collaborator

Removing existing api routes can break existing users. Better to keep the old one and add get_server_info on top

@merrymercy
Copy link
Contributor

I do not think they are ever used by any non-core developers, so we do not need to worry about the backward compatibility now.

@merrymercy merrymercy merged commit dbe1729 into sgl-project:main Nov 24, 2024
15 checks passed
@binarycrayon
Copy link
Contributor

we actually use it, would love to get some warning about breaking changes in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants