Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(flashinfer): fix is_flashinfer_available() and make flashinfer optional dependency #2132

Closed
wants to merge 1 commit into from

Conversation

XuehaiPan
Copy link
Contributor

@XuehaiPan XuehaiPan commented Nov 23, 2024

Motivation

In the document, we need to install flashinfer manually after installing sglang.

Users cannot import SRT successfully if flashinfer is not installed.

Modifications

Return False in is_flashinfer_available() if flashinfer is not installed.

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@XuehaiPan XuehaiPan changed the title deps(srt): fix is_flashinfer_available() and make flashinfer optional dependency deps(flashinfer): fix is_flashinfer_available() and make flashinfer optional dependency Nov 23, 2024
python/sglang/srt/utils.py Show resolved Hide resolved
@zhyncs zhyncs closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants