Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak for chunked prefill 2 #1858

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Fix memory leak for chunked prefill 2 #1858

merged 6 commits into from
Oct 31, 2024

Conversation

merrymercy
Copy link
Contributor

@merrymercy merrymercy commented Oct 31, 2024 •
edited
Loading

Simplified version of #1837

  • Fix a memory leak around self.being_chunked_req.init_next_round_input()
  • Renamecurrent_inflight_req -> being_chunked_req
  • Rename is_inflight_req -> is_being_chunked

@merrymercy merrymercy changed the title Fix memory leak 2 Fix memory leak for chunked prefill 2 Oct 31, 2024
@merrymercy merrymercy merged commit a2e0424 into main Oct 31, 2024
0 of 12 checks passed
@merrymercy merrymercy deleted the pr-fix-leak branch October 31, 2024 21:51
@merrymercy merrymercy mentioned this pull request Oct 31, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@merrymercy