-
Notifications
You must be signed in to change notification settings - Fork 27
[Feature] Add LlamaCPP as server engine option #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @rgerganov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces LlamaCPP as a new server engine option within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds LlamaCPP as a server engine option. While this is useful for metadata, the implementation is incomplete for providing full, user-friendly support for llama.cpp as a backend. For consistency with other OpenAI-compatible backends like vLLM and SGLang, LlamaCPP should also be added as an --api-backend option. I've left a comment with details on how to achieve this. Making these changes will significantly improve the usability and maintainability of this new feature.
genai_bench/cli/option_groups.py
Outdated
| ["vLLM", "SGLang", "TGI", "cohere-TensorRT", "cohere-vLLM", | ||
| "LlamaCPP"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding LlamaCPP to --server-engine is a good step for metadata. However, to provide a complete and user-friendly integration for llama.cpp, it should also be treated as a first-class API backend, similar to vLLM and SGLang.
This would involve:
- Adding
llamacpp(lowercase, for consistency) to theclick.Choicefor the--api-backendoption inapi_optionswithin this file. - In
genai_bench/cli/validation.py, adding'llamacpp': OpenAIUserto theAPI_BACKEND_USER_MAP. - Also in
genai_bench/cli/validation.py, adding'llamacpp'to theapi_key_requiredlist invalidate_api_key. - In
genai_bench/cli/cli.py, adding'llamacpp'to the lists forauth_kwargsandauth_backend_mapto handle authentication.
These changes would make LlamaCPP a fully supported backend, improving consistency and user experience.
|
@rgerganov Can you fix the CI failure? And please take a look at the above comment from gemini. |
llama.cpp is exposing OpenAI compatible APIs and works perfectly fine with genai-bench.
2d13f3d to
7b009aa
Compare
The CI should be fixed now but I cannot trigger it. The gemini comment doesn't make sense -- llamacpp is exposing OpenAI backend and doesn't require API keys, so no other changes are needed, similar to the |
Description
llama.cpp is exposing OpenAI compatible APIs and works perfectly fine with genai-bench. This patch adds it as server engine option