Repository navigation
Normalise performance improvements - #66
Merged
Merged
Conversation
Member
|
It's fiddly - let's just use the absolute chunk count for now, it's a good starting point. |
Member
Author
|
OK, here's the minimal useful version. Waiting for #65 to go in. |
tomwhite
marked this pull request as ready for review
April 29, 2026 15:54
Member
|
Can we standardise on explicitly saying |
tomwhite
force-pushed
the
normalise-parallelism
branch
from
April 29, 2026 17:16
f2b63d9 to
f776670
Compare
Member
|
LGTM |
tomwhite
force-pushed
the
normalise-parallelism
branch
from
April 29, 2026 19:51
fc13415 to
db02298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP attempt to process a batch of chunks at a time. A workload of 700k variants, 1 sample went from 43s to 5s, so this is worth doing.
@jeromekelleher you mentioned using a memory budget - do we have any code that does something like that already?