Repository navigation
Make normalise work chunk by chunk - #46
Merged
Merged
Conversation
Add unit test for remap_genotypes Parameterize test_normalise with more values of variants_chunk_size Update README with mention of vczstore normalise
Member
Author
|
Part of #30 |
| data[local_idx, ...] = arr[match_sl, ...] | ||
|
|
||
| def remap_genotypes(gt, allele_mappings): | ||
| if var == "call_genotype": |
Member
There was a problem hiding this comment.
We don't need to implement right away, but it's more general than just genotypes. We'd need to remap any field with dimensions alleles, alt_alleles, or genotypes, as well as local alleles. We should assert on finding any of these for now, I guess.
Member
Author
There was a problem hiding this comment.
Good point. I've added a check for this and a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit test for remap_genotypes
Parameterize test_normalise with more values of variants_chunk_size
Update README with mention of vczstore normalise