You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's unlikely we'll be able to predict all alleles ahead of time. The simplest approach is to append the new allele(s) to the variant_alleles array and to recode the genotypes in the input data. Note that this means we'll also need to detect inconsistent allele encodings and deal with those.
This seems like a reasonable line to draw for altering the data on append - so, we hard-require that the data has the right dimensions (#30), but we update the encoding as necessary.
There's some code in #21 that I removed (as I wasn't sure it was the right way of doing things) that would actually help to do this. Let's revisit that code when we meet that requirement (probably when dealing with imputed data).
Activity
tomwhite commentedon Apr 13, 2026
There's some code in #21 that I removed (as I wasn't sure it was the right way of doing things) that would actually help to do this. Let's revisit that code when we meet that requirement (probably when dealing with imputed data).
tomwhite commentedon May 6, 2026
Fixed in #77