Skip to content

Dealing with new alleles during append #31

Closed

Description

@jeromekelleher

It's unlikely we'll be able to predict all alleles ahead of time. The simplest approach is to append the new allele(s) to the variant_alleles array and to recode the genotypes in the input data. Note that this means we'll also need to detect inconsistent allele encodings and deal with those.

This seems like a reasonable line to draw for altering the data on append - so, we hard-require that the data has the right dimensions (#30), but we update the encoding as necessary.

Activity

  1. tomwhite commented on Apr 13, 2026

    @tomwhite
    Member

    There's some code in #21 that I removed (as I wasn't sure it was the right way of doing things) that would actually help to do this. Let's revisit that code when we meet that requirement (probably when dealing with imputed data).

  2. self-assigned this
    on Apr 16, 2026
  3. tomwhite commented on May 6, 2026

    @tomwhite
    Member

    Fixed in #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions