F1 + F2 follow-ups: fail-closed demo mode, computed cost fallback, first tests, CI#2
Merged
Conversation
- F1: demo processor is fail-closed — refuses without DEMO_MODE=true (no GitHub call possible before the gate, proven by test with an exploding client proxy); when enabled, the summary comment and every inline comment are prominently labeled as canned demo output - F2: unknown-model pricing fallback is now COMPUTED as the most expensive listed model (was gpt-4 while claiming max — gpt-4-32k costs 2x); the fail-closed property is asserted by test against every listed model - First tests in this repo (node:test over dist, zero new deps) + CI: build+test on Node 20/22, Docker build validation (closes the deferred Sprint-5.1 item) - README banner updated: repaired state, benchmark case-study pointer, honest claim level (built, not live-proven)
…ev then ran tsc (a devDependency); it could never build. Build stage compiles, runtime ships prod deps + dist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the PR #1 review, resolved for maximum credibility rather than minimum patch:
F1 — undisclosed demo output → structurally impossible
DEMO_MODE !== 'true'→ the PR_ANALYSIS job fails with an explicit reason and posts nothing. A default deployment can no longer present fabricated findings — safety by structure, not by label.F2 — the fail-closed pricing claim is now computed, not asserted
maxover the pricing table (was hardcoded gpt-4 while gpt-4-32k costs 2×). Test asserts the fallback ≥ every listed model, so the guarantee can't silently rot when prices are edited.First tests + CI (closes deferred Sprint-5.1)
node:testover compiled dist — zero new dependencies; 3/3 green locally.README