Win32 (and friends) #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improved MSVC x64 support suggested by robertolarcher (Pull Request libnet#58), README.win32 adjustments, added (Linux only) Travis test yml as well as other tiny fixes.
last chance, appveyor1
msvcbuild.bat now builds libnet from ANY cmd/powershell not just the Developer Command Prompt
goto %1 didn't apply anymore...
batch file now creates "lib" folder, libs have version number and other minor changes; lua bindings doesn't work (yet)
Samples are in need of additional linking (-lws2_32, -lpcap) and are complaining about code in libnet_resolve.c, libnet_write.c and libnet_raw.c. Not sure how concerning that is... I better get my pcap manual :-D
Libnet now builds gracefully with MinGW (including samples). There's a lot of fine tuning to be done and it needs testing on my other MinGW distros (including cross). This push is therefore just to see if Linux, Mac and Windows (MSVC) are still happy.
the build system should be up to the latest standards with this one. Except for docs, that's up next...
still ugly, but at least it works again
This was suprisingly easy. Hail clang!
On Linux at least, most if not all ethertypes defined in libnet-headers.h are also defined in the compiler's standard include files (net/ethertypes.h, linux/if_ether.h and maybe others too) That's not a problem because ethertypes are a IEEE 802.3 standard. But for some reason, the Hex letter digits in libnet-headers.h are all lowercase but those in the standard include files are all uppercase (as they are throughout all RFCs(see RFC7042 and RFC2464). This harmless macro redefinition causes clang (and maybe others too) to go berserk. Maybe it's time to let the standard include files handle ethertypes instead of libnet-headers.h. For now, I am just going to add diagnostic pragmas to the conflicting ethertypes to suppress macro redefinition warnings caused this way.
Even though libnet.h is always regenerated by configure, having it around still has some benefits (with respect to documentation) - Docs can be created independently from building (by running doxygen doc/libnet.doxygen.conf) - Docs can be hosted from within the repo (via codedocs.xyz)
yet another attempt to come after Travis build error by updating autoconf and libnet before building
We'll switch to the pax interchange format defined by POSIX 1003.1-2001
comments are also from now on preceded by a '#' rather that the 'dnl'
a very generic one
i forgot why, but pcap/pcap.h should be included after winsock2.h and windows.h
we shall do this differently....
sgeto
force-pushed
the
master
branch
4 times, most recently
from
7de8795 to
41eb411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.