-
Notifications
You must be signed in to change notification settings - Fork 3
주식 상세 페이지 레이아웃 구성하기 #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7bb2d44
#65 feat(fe): resizable을 이용한 헤더 및 레이아웃 구조 잡기
KimKyuHoi c28f3f3
#65 feat(fe): 전체 레이아웃 및 not-found page 설정하기
KimKyuHoi 8653896
#65 feat(fe): 전체 레이아웃 내 메인페이지 layout 설정하기
KimKyuHoi ff4a208
#65 feat(fe): 주식 상세페이지 layout 상세 구성
KimKyuHoi 9cbdf93
#65 feat(fe): chatbox 레이아웃 구성
KimKyuHoi 0a6ca5c
#65 feat(fe): stockSlug내에서 metadata 생성 예정
KimKyuHoi e6f3420
#65 refactor(fe): div태그 제거
KimKyuHoi 54d9742
#65 refactor(fe): ChatBox -> ChatContainer 명 변경
KimKyuHoi 8dc33b9
#65 feat(fe): stocklayout 구현
KimKyuHoi 33b7030
#65 feat(fe): 전체 layout 구성 및 전체 모듈화 경로 설정
KimKyuHoi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import { ResizablePanelGroup, ResizablePanel, ResizableHandle } from '@workspace/ui/components'; | ||
|
|
||
| import Chatbox from '@/src/features/chat/chatbox'; | ||
|
|
||
| // 주식데이터를 가지고 올수있는 방법이 필요합니다. | ||
|
|
||
| export async function generateMetadata({ params }) { | ||
| const { stockSlug } = params; | ||
|
|
||
| return { | ||
| title: `${stockSlug} - 주식 정보`, | ||
| description: `${stockSlug}의 최신 주식 정보를 확인하세요.`, | ||
| keywords: `주식, ${stockSlug}, 주식 정보`, | ||
| }; | ||
| } | ||
|
|
||
| export default function StockDetailsPage({ params }) { | ||
| const { stockSlug } = params; | ||
| // console.log(1, params); | ||
|
|
||
| return ( | ||
| <div className="flex flex-1 flex-row"> | ||
| <div className="flex items-center justify-center bg-gray-200 w-[45%] h-full">Stock Chart</div> | ||
|
|
||
| <div className="flex items-center justify-center py-6 pr-[30px] pl-2 bg-gray-400 w-[55%] h-full"> | ||
| <Chatbox /> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import '@workspace/ui/globals.css'; | ||
|
|
||
| export default function RootLayout({ | ||
| children, | ||
| }: Readonly<{ | ||
| children: React.ReactNode; | ||
| }>) { | ||
| return ( | ||
| <html | ||
| lang="en" | ||
| suppressHydrationWarning | ||
| > | ||
| <body> | ||
| <header className="h-[68px] bg-gray-800 flex items-center justify-center text-white">Header</header> | ||
| <div className="flex flex-col h-[calc(100vh-68px)] overflow-hidden">{children}</div> | ||
| </body> | ||
| </html> | ||
| ); | ||
| } |
6 changes: 5 additions & 1 deletion
6
src/frontend/apps/web/app/page.tsx → src/frontend/apps/web/app/(main)/page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import Link from 'next/link'; | ||
| import { NextPage } from 'next'; | ||
| import { Button } from '@workspace/ui/components'; | ||
|
|
||
| const NotFound: NextPage = () => { | ||
| return ( | ||
| <div className="flex items-center justify-center min-h-svh"> | ||
| <div className="flex flex-col items-center justify-center gap-4"> | ||
| <div>이 페이지는 존재하지 않습니다. 매인 페이지로 이동하세요.</div> | ||
| <Button> | ||
| <Link href="/">메인페이지로 이동하기</Link> | ||
| </Button> | ||
| </div> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default NotFound; |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| const Chatbox = () => { | ||
| return <div className="bg-gray-200 w-full h-full">123</div>; | ||
| }; | ||
|
|
||
| export default Chatbox; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pl외의 다른 패딩값은 주식과 채팅 동일하게 한번에 적용하시는건 어떠신가요? 이렇게 하신 이유가 있다면 수정하지 않으셔도 됩니다!

저는 와이어프레임 기준 주식차트와 채팅의 양쪽과 아래쪽 패딩이 일치하다고 생각했는데 채팅만 따로 패딩값을 주신게 궁금합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하 요거까진 제가 따로 고려하진 않았었는데 좋은 것 같습니다. 수정하겠습니다. (:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@handje

새로운 레이이아웃을 전부 적용과 나머지 컴포넌트 모듈화까지 진행했습니다!
컴포넌트 명 같은 경우에는 제가 고민해봤을때
Layout은 페이지나 섹션의 레이아웃을 정의하기때문에 StockLayout으로
Container는 보통 구성 요소들을 담는 역할을 하는 컴포넌트이기때문에 Chatbox -> ChatContainer로 수정해보았습니다. 한번 컨펌해주시면 감사하겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
깔끔하고 좋네요! 👍 👍