Skip to content

Conversation

@handje
Copy link
Collaborator

@handje handje commented Jan 27, 2025

Pull request

Related issue

Resolve #14 @handje

Motivation and context

  • 사용자 아바타 클릭 시 , 사용자 정보, 수정버튼, 로그아웃버튼을 보여주는 popover 구현
  • popover에 사용되는 Input / Label 구현

Solution

Popover

  • PopoverTrigger : popover가 보여지도록 하는 버튼 or 아바타
  • PopoverContent : popover가 눌렸을 때 보여지는 요소
<Popover>
  <PopoverTrigger>Open</PopoverTrigger>
  <PopoverContent>Place content for the popover here.</PopoverContent>
</Popover>

Label & Input

 <div className="flex w-full items-center space-x-2">
      <Label htmlFor='name'>Name</Label>
      <Input
        id='name'
        placeholder='Enter your name'
        disabled={false}
      />
</div>

How has this been tested

image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@handje handje requested a review from KimKyuHoi January 27, 2025 04:19
@handje handje self-assigned this Jan 27, 2025
@handje handje added ✨ Feature 기능 추가 💄 Design 프론트엔드 CSS 관련 이슈 🖥️ FE 프론트엔드 무조건 스프린트내에 해야하는 것들 labels Jan 27, 2025
@handje handje added this to the 주톡피아 마일스톤 1 milestone Jan 27, 2025
Copy link
Collaborator

@KimKyuHoi KimKyuHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@handje handje merged commit 6c38aab into dev Jan 28, 2025
2 of 3 checks passed
@handje handje deleted the fe-feat/popover branch January 30, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

무조건 스프린트내에 해야하는 것들 💄 Design 프론트엔드 CSS 관련 이슈 🖥️ FE 프론트엔드 ✨ Feature 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PopOver 기능 구현하기

3 participants