#33 feat(be): 채널가입 api 구현 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ki-met-hoon
reviewed
Jan 24, 2025
Collaborator
ki-met-hoon
left a comment
ki-met-hoon
left a comment
There was a problem hiding this comment.
고생하셨습니다!! 작업 속도가 너무 빨라서 자극을 받고 있습니다👍
| WorkSpace workSpace = fetchWorkSpace(workspaceId); | ||
|
|
||
| // 워크스페이스에 채널 있는지 | ||
| if (!IsChannelInWorkSpace(workspaceId, channelId)) { |
Collaborator
There was a problem hiding this comment.
해당 if문을 method화 하면 책임 분리가 더 뚜렷해질 것 같아요..!
| Channels channel = fetchChannel(channelId); | ||
| Users user = fetchUser(userId); | ||
|
|
||
| UserChannel userChannel = UserChannel.builder() |
Collaborator
There was a problem hiding this comment.
큰 것도 잘못된 것도 아니지만, 저는 Entity나 DTO를 만들때 해당 class의 변수들의 노출을 막고 싶어 정적 팩토리 메서드를 즐겨 사용합니다! 이건 고쳤으면 좋겠다가 아니라 저는 이렇게 즐겨 한다~ 입니다!!
https://tecoble.techcourse.co.kr/post/2020-05-26-static-factory-method/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Related issue
#33
Motivation and context
워크스페이스 내 채널 가입 api 구현
요청 @PathVariable Long workspaceId, @PathVariable Long channelId
응답
success
Solution
How has this been tested
가입 성공의 경우 success 응답
이미 가입한 경우 위의 사진과 같이 응답
Types of changes
Checklist