워크스페이스 채널생성 API 구현 #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ki-met-hoon
reviewed
Jan 24, 2025
Collaborator
ki-met-hoon
left a comment
ki-met-hoon
left a comment
There was a problem hiding this comment.
고생하셨습니다~! 피드백 잘 반영되어 있어서 좋습니다👍
몇가지 궁금한 점들을 남겨놨어요!
|
|
||
| private final WorkSpaceService workSpaceService; | ||
| private final Long userId = JootalkpiaAuthenticationContext.getUserInfo().userId(); | ||
| private final Long userId = 1L;//JootalkpiaAuthenticationContext.getUserInfo().userId(); |
Member
Author
There was a problem hiding this comment.
네 로컬에서 테스트할 때는 일단 이런 식으로 해야해요! 근데 배포 환경에서 어떻게 해야할지 보람님과 이야기하긴 했는데 정하진 못해서 나중에 논의합시당!
|
|
||
| @Getter | ||
| @MappedSuperclass | ||
| public abstract class BaseEntity { |
Collaborator
There was a problem hiding this comment.
ID 필드는 넣지 않은 이유가 있을까요?
Member
Author
There was a problem hiding this comment.
아이디는 그냥 id로 이름짓지말고 channel_id 이런 식으로 하라고 캠프장님이 말씀하셨어서 base entity로 따로 빼기가 애매하다고 판단했기 때문입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Related issue
#32
Motivation and context
Solution
요청 @PathVariable Long workspaceId, @RequestParam String channelName
응답: 생성된 채널 정보
public class SimpleChannel {
private Long channelId;
private String channelName;
private LocalDateTime createdAt;
}
How has this been tested
Types of changes
Checklist