Skip to content

Conversation

@handje
Copy link
Collaborator

@handje handje commented Feb 26, 2025

Pull request

Related issue

Resolve #306 @handje

Motivation and context

  1. 알림 구독 연결

Solution

  1. toaster로 연결되어 기존에 구현하신 새메시지 알림과 겹칠수있습니다. 이 부분은 추후에 다른 뷰로 고민해봐야할 듯 합니다 @KimKyuHoi
  2. 알림을 filter하는 로직이 추가로 필요합니다. 지금은 테스트가 어려워 필터링은 따로 구현하지 않은 상태입니다.

How has this been tested

  1. userId, channelId 를 테스트 가능하게 설정해야 테스트가 가능합니다.
    ex) 100번유저-3번채널 , 101번유저-5번 채널로 설정 후, 100번유저가 3번방에 채팅을 보내면 101번에게 알림이옴
    image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@handje handje added ✨ Feature 기능 추가 🖥️ FE 프론트엔드 ♻️ Need To Refactor 추후 리팩토링이 필요한 이슈 및 논의 무조건 스프린트내에 해야하는 것들 labels Feb 26, 2025
@handje handje added this to the 주톡피아 마일스톤3 milestone Feb 26, 2025
@handje handje requested a review from KimKyuHoi February 26, 2025 15:57
@handje handje self-assigned this Feb 26, 2025
@netlify
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for jootalkpia ready!

Name Link
🔨 Latest commit b9bcaa9
🔍 Latest deploy log https://app.netlify.com/sites/jootalkpia/deploys/67bfd159716ff5000811aabb
😎 Deploy Preview https://deploy-preview-310--jootalkpia.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@KimKyuHoi KimKyuHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍 오늘중으로 PR 워크스페이스 올리겠습니다

@handje handje merged commit 9daf75b into dev Feb 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🖥️ FE 프론트엔드 ✨ Feature 기능 추가 ♻️ Need To Refactor 추후 리팩토링이 필요한 이슈 및 논의 무조건 스프린트내에 해야하는 것들

Projects

None yet

Development

Successfully merging this pull request may close these issues.

알림 구독

3 participants