Skip to content

주식차트 웹소켓 데이터 적용 #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
handje merged 19 commits into from
Feb 27, 2025
Merged

주식차트 웹소켓 데이터 적용 #305

handje merged 19 commits into from
Feb 27, 2025

Conversation

@handje
Copy link
Collaborator

@handje handje commented Feb 26, 2025 •
edited
Loading

Pull request

Related issue

Resolve #273 @handje

Motivation and context

  1. 웹소켓 데이터 적용

Solution

  1. api호출이 초기에 불러지고 이후에 추가될 데이터 입니다
  2. 현재는 데이터로 인해 차트가 제대로 보이지 않고 있습니다.
    잘못된 커밋 메시지가 삭제되지 않은채로 남아있습니다. 참고 부탁드릴게요!

How has this been tested

주식차트 웹소켓

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

handje added 17 commits February 23, 2025 17:27
@handje
#273 feat(fe) : 주식 ws구독
31dd60d
@handje
#273 feat(fe) : 주식 query-key 추가
a84ce46
@handje
#273 feat(fe) : 주식 setQuery 구현
af3731a
@handje
#273 feat(fe) : 주식sub 연결
3fbf6da
@handje
#273 feat(fe) : 캐싱된 주식 데이터 불러오기
7409a5b
@handje
#273 refactor(fe): 주식, 차트 타입 분리
e743ab0
@handje
#273 feat(fe): 주식 리스트 상수 선언
aba57d4
@handje
#273 feat(fe) : 주식 상수 매핑 구현
c29fa6e
@handje
#273 fix(fe): import경로 에러 수정
18994be
@handje
#273 feat(fe): slug 변환 및 props전달
5e8361c
@handje
#273 fix(fe): 매핑 객제 삭제 및 상수 객체 변경
9822928
@handje
#273 fix(fe):코드별 주식쿼리로 변경
7cfed25
@handje
#273 feat(fe):타입 추가 및 필요없는 export삭제
ab237f2
@handje
#273 feat(fe): 더미데이터 실제 쿼리데이터로 변경 및 변수 수정
c3e75e7
@handje
r
9c248dd
@handje
Merge branch 'dev' of https://github.com/sgdevcamp2025/c_sharp into f…
a7da1e3 
…e-feat/stock-ws
@handje
#260 feat(fe): 웹소켓 데이터 차트 적용
c2a2df5
@netlify
Copy link

netlify bot commented Feb 26, 2025 •
edited
Loading

✅ Deploy Preview for jootalkpia ready!

Name Link
🔨 Latest commit bf95bc9
🔍 Latest deploy log https://app.netlify.com/sites/jootalkpia/deploys/67bfe74fe90fac0008ca93fe
😎 Deploy Preview https://deploy-preview-305--jootalkpia.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@handje handje requested a review from KimKyuHoi February 26, 2025 07:54
@handje handje self-assigned this Feb 26, 2025
@handje handje added ✨ Feature 기능 추가 🖥️ FE 프론트엔드 ♻️ Need To Refactor 추후 리팩토링이 필요한 이슈 및 논의 상 무조건 스프린트내에 해야하는 것들 labels Feb 26, 2025
@handje handje added this to the 주톡피아 마일스톤3 milestone Feb 26, 2025
KimKyuHoi
KimKyuHoi approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@KimKyuHoi KimKyuHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@handje handje merged commit 5ae33ca into dev Feb 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KimKyuHoi KimKyuHoi KimKyuHoi approved these changes

Assignees

@handje handje

Labels

🖥️ FE 프론트엔드 ✨ Feature 기능 추가 ♻️ Need To Refactor 추후 리팩토링이 필요한 이슈 및 논의 상 무조건 스프린트내에 해야하는 것들

Projects

None yet

Milestone

주톡피아 마일스톤3

Development

Successfully merging this pull request may close these issues.

주식 웹소켓 연결

3 participants

@handje @KimKyuHoi