Skip to content

Conversation

@handje
Copy link
Collaborator

@handje handje commented Feb 23, 2025

Pull request

Related issue

Resolve #259 @handje

Motivation and context

  1. 로그아웃 버튼 클릭 시, 로컬스토리지 및 쿠키 내용 삭제 후 루트페이지로 리다이렉트
  2. 로그인 후, 실제 정보로 popover적용

Solution

추후 리팩토링 필요

  1. 로그인 후, 로컬스토리지에 저장되고 /stock 페이지로 넘어가는 과정에서 딜레이가 발생합니다.
  2. 로그아웃 후, 루트페이지로 돌아가기 전에 저장된 정보가 지워지며 유저 프로필이 먼저 비워지는 불편함이 있습니다.
  3. dev에서 stric모드로 인해 두번 실행되며 로그인 에러가 발생합니다. stric mode=false에서는 동작에 문제가 없지만, 이부분은 추후에 다시 확인해볼 예정입니다.
  4. 개발 완료 후, AuthWrapper 수정 예정입니다.

How has this been tested

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@netlify
Copy link

netlify bot commented Feb 23, 2025

Deploy Preview for jootalkpia ready!

Name Link
🔨 Latest commit 0087fce
🔍 Latest deploy log https://app.netlify.com/sites/jootalkpia/deploys/67bab63da1bb270008cad1ae
😎 Deploy Preview https://deploy-preview-272--jootalkpia.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@handje handje requested a review from KimKyuHoi February 23, 2025 05:48
@handje handje self-assigned this Feb 23, 2025
@handje handje added ✨ Feature 기능 추가 🖥️ FE 프론트엔드 ♻️ Need To Refactor 추후 리팩토링이 필요한 이슈 및 논의 무조건 스프린트내에 해야하는 것들 labels Feb 23, 2025
@handje handje added this to the 주톡피아 마일스톤3 milestone Feb 23, 2025
Copy link
Collaborator

@KimKyuHoi KimKyuHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 달리시죠

@handje handje merged commit 0fe651b into dev Feb 23, 2025
6 checks passed
@handje handje deleted the fe-feat/logout branch February 25, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🖥️ FE 프론트엔드 ✨ Feature 기능 추가 ♻️ Need To Refactor 추후 리팩토링이 필요한 이슈 및 논의 무조건 스프린트내에 해야하는 것들

Projects

None yet

Development

Successfully merging this pull request may close these issues.

유저프로필 popover 실제 데이터 적용 및 로그아웃

3 participants