Skip to content

Conversation

@handje
Copy link
Collaborator

@handje handje commented Feb 19, 2025

Pull request

Related issue

Resolve #241 @handje

Motivation and context

  1. 로컬스토리지를 쿠키로 변경
  2. 서버 api인 cookies() 사용
  3. fetch instance를 서버액션으로 정의

Solution

'use server';

const token = cookies().get('token')?.value;

How has this been tested

  1. 개발자도구에서 쿠키 입력
    쿠키

  2. 로그 확인
    쿠키로그

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the docs/CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@handje handje added ✨ Feature 기능 추가 🖥️ FE 프론트엔드 ♻️ Need To Refactor 추후 리팩토링이 필요한 이슈 및 논의 무조건 스프린트내에 해야하는 것들 labels Feb 19, 2025
@handje handje added this to the 주톡피아 마일스톤3 milestone Feb 19, 2025
@handje handje requested a review from KimKyuHoi February 19, 2025 13:41
@handje handje self-assigned this Feb 19, 2025
@netlify
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for jootalkpia ready!

Name Link
🔨 Latest commit 1c13381
🔍 Latest deploy log https://app.netlify.com/sites/jootalkpia/deploys/67b5df9766da9c0008c7e323
😎 Deploy Preview https://deploy-preview-244--jootalkpia.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@KimKyuHoi KimKyuHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍 👍

@handje handje merged commit 85d26bd into dev Feb 20, 2025
6 checks passed
@handje handje deleted the fe-feat/localstorage-to-cookie branch February 25, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🖥️ FE 프론트엔드 ✨ Feature 기능 추가 ♻️ Need To Refactor 추후 리팩토링이 필요한 이슈 및 논의 무조건 스프린트내에 해야하는 것들

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fetch instance 쿠키 적용

3 participants